Repository navigation
Fix pinch-to-zoom on the canvas - #249
Merged
Merged
Conversation
Deploying showcode with
|
| Latest commit: |
78eff97
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://67df2078.showcode.pages.dev |
| Branch Preview URL: | https://fix-canvas-pinch-zoom.showcode.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trackpad pinch gestures weren't connected to the canvas zoom controls, so pinching could zoom the page instead of the canvas. Touchscreen pinches could resize the canvas, but left the zoom slider and saved viewport at their previous scale.
I've connected trackpad pinches to smooth zooming around the pointer and kept the controls and saved viewport in sync with gesture changes. Gestures use the same 20–200% range as the slider, work across the canvas area, and leave ordinary scrolling alone.
Verified with the full test suite (160 tests passing), the desktop renderer build, and the GitHub Actions test and Cloudflare production-build jobs.